Add Greek Language ('el') Support and Internationalization#6677
Conversation
|
Amazing. Are there any native greek speakers available to review this? |
|
@pfrazee I can help with that. Should we ensure all things are translated on this PR or can it be split in smaller PRs? |
I think it's beneficial to have a good start for a first translation PR, so it would be best to continue improving this PR until it's ready to be merged. |
ipinak
left a comment
There was a problem hiding this comment.
Here are some comments to begin with. Let me know what you think about them.
|
Everyone here is amazing -- for the initial translation and the review. I'm going to let this keep cooking because it looks like not everything is resolved yet. |
dpkgme
left a comment
There was a problem hiding this comment.
Έκανα πάλι ένα πέρασμα.
Προτείνω όπου starter pack => πακέτο έναρξης.
Για τα feeds μάλλον τείνω προς ροές.
Κάτι που με προβληματίζει λίγο είναι η συμπεριληπτικότητα σε κάποια σημεία, π.χ. έχω προτείνει "Θέλετε σίγουρα...;αντί γιαΕίστε σίγουροι...;`. Ας το σκεφτούμε.
|
Would it be possible to add one more change to this PR to enable the Greek localization? If you could add an Lines 101 to 102 in 770eeb5 This will enable Greek to be displayed as a supported language in the App Store listing, and it will also allow the |
Added! |
|
@ipinak @dpkgme @bekatoros @stergioc I don't know if I am forgetting something. I am doing a last pass of the messages.po, to see if it's missing something and I will push the commit. |
I'm not seeing |
@imertz I agree with what you said. |
…slation from the reviewers' comments
I did a last check on the messages.po. |
Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
pfrazee
left a comment
There was a problem hiding this comment.
Exciting!! Thanks so much everybody!
|
@pfrazee I saw that you're merging some translation PRs, so maybe this one could be too? :) |
Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
pfrazee
left a comment
There was a problem hiding this comment.
Agree! Awesome, thanks all!
This PR adds full internationalization support for the Greek language, using the ISO 639-1 language code 'el'.