Fix skeleton alignment#6676
Merged
Merged
Conversation
arcalinea
temporarily deployed
to
fix-placeholder-sizes - social-app PR #6676
Render
Destroyed
gaearon
commented
Nov 23, 2024
| }, | ||
| avatar: { | ||
| borderRadius: 26, | ||
| borderRadius: 999, |
Contributor
Author
There was a problem hiding this comment.
so we don't have to keep updating this.
gaearon
requested review from
estrattonbailey,
haileyok,
mozzius and
pfrazee
Contributor
|
estrattonbailey
approved these changes
Nov 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Notifications skeleton alignment to match the actual sizes (which changed at some point).
This gets the left top avatar to pixel-perfect alignment.
Test Plan
web.mov
ios.mov
android.mov