Fix jumpy web animation for modal backdrop#6673
Merged
Merged
Conversation
arcalinea
temporarily deployed
to
fix-animation-jump - social-app PR #6673
Render
Destroyed
gaearon
requested review from
estrattonbailey,
haileyok,
mozzius and
pfrazee
estrattonbailey
approved these changes
Nov 23, 2024
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to stop trying to use Reanimated layout and enter/exit animations on web. They just don't work well. There's no point to trying. We keep getting affected by their glitches and there's no benefit because CSS works much better. Let's avoid them (on web) going forward.
I reused an existing animation name.
Test Plan
Modal backdrops are no longer glitching on web.
lite.mov
dark.mov
dim.mov