Fix Newline handling in Web's Composer#6658
Merged
gaearon merged 1 commit intoNov 23, 2024
Merged
Conversation
Closed
gaearon
approved these changes
Nov 23, 2024
Contributor
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
thanks, this was very annoying but i couldn't tell where the mistake is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes copying and pasting text that includes line breaks (
\n) in the Web Composer.Tiptap doesn't maintain newlines because this is a default from Prosemirror. Context: ueberdosis/tiptap#775 (comment)
Fixes #6365.
Changes:
blockSeparatorto\ninstead of the default\n\n. Fixes the copying behavior.clipboardTextParser. The same as the code provided by @glavdir in Paste from notepad ueberdosis/tiptap#775 (comment), but with type annotations.Manual testing
2024-11-23_15-47-03.mp4