Skip to content

Fix translate button not working #6657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 2 commits into from
Nov 23, 2024
Merged

Fix translate button not working #6657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd84d7c
Update PostThreadItem.tsx
auroursa Nov 23, 2024
8dd11d2
Fix in-app browser usage
gaearon Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/view/com/post-thread/PostThreadItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import React, {memo, useMemo} from 'react'
import {StyleSheet, Text as RNText, View} from 'react-native'
import {
GestureResponderEvent,
StyleSheet,
Text as RNText,
View,
} from 'react-native'
import {
AppBskyFeedDefs,
AppBskyFeedPost,
Expand Down Expand Up @@ -736,9 +741,14 @@ function ExpandedPostDetails({
const openLink = useOpenLink()
const isRootPost = !('reply' in post.record)

const onTranslatePress = React.useCallback(() => {
openLink(translatorUrl, true)
Comment thread
gaearon marked this conversation as resolved.
Outdated
}, [openLink, translatorUrl])
const onTranslatePress = React.useCallback(
(e: GestureResponderEvent) => {
e.preventDefault()
openLink(translatorUrl, true)
return false
},
[openLink, translatorUrl],
)

return (
<View style={[a.gap_md, a.pt_md, a.align_start]}>
Expand All @@ -757,7 +767,7 @@ function ExpandedPostDetails({
</Text>

<InlineLinkText
to="#"
to={translatorUrl}
label={_(msg`Translate`)}
style={[a.text_sm, pal.link]}
onPress={onTranslatePress}>
Expand Down