Fix interstitials to not interrupt feed slices#6645
Merged
Conversation
arcalinea
temporarily deployed
to
fix-interstitials - social-app PR #6645
Render
Destroyed
gaearon
requested review from
estrattonbailey,
haileyok,
mozzius and
pfrazee
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I regressed on this in #6507. We never want to put an interstitial in between two items of the same slice. To fix this, I'm moving the logic to where we enumerate over the slices. While we're at it, I'm also ripping out a bit of abstraction that hasn't proven out to be useful and was making my mistake harder to spot. (Plus removing the experiment we didn't ship.)
Test Plan
Reset onboarding state, observe the progress bar on Discover:
Discover still shows suggestions:
They change after Discover invalidation.
Profiles still show suggestions: