Simplify play icon shadow#6641
Merged
Merged
Conversation
Contributor
|
mozzius
approved these changes
Nov 22, 2024
Member
mozzius
left a comment
There was a problem hiding this comment.
I don't exactly get the motivation but it works fine
Contributor
Author
See the summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves a few things:
shadowColorwas theme-dependent (which doesn't make sense when overlaying a video).Raised button causing error: View #... of type RCTView has a shadow set but cannot calculate shadow efficientlywhich is only solveable by putting a solid background color on the element with the shadow.Should overall look the same-ish. Here it is against different backgrounds: