[Android] Lower Feed maxRenderPerBatch#6624
Merged
Merged
Conversation
arcalinea
temporarily deployed
to
lower-maxbatch - social-app PR #6624
Render
Destroyed
Contributor
|
haileyok
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These batches can drop frames really hard since each row is a feed story (which may have embeds etc).
Let's just be conservative on Android and try to unblock as much as possible. I'm not seeing a lot of blank spaces in practice unless I scroll super hard. Whereas the frame-by-frame improvement is quite noticeable, especially on embed-heavy feeds like the News feed. And I assume on higher end it'll work even better.
Test Plan
Scroll up and down different feeds.
Also try "scroll to top" and scrolling down after to try to trigger blanks.
Before
This was captured with the News feed (which has embeds and is consistently ordered). Five scrolls down with momentum.
After
Same, five scrolls on News feed.
And it just feels better, you know.