Reduce overdraw#6617
Merged
Merged
Conversation
arcalinea
temporarily deployed
to
feed-overdraw - social-app PR #6617
Render
Destroyed
gaearon
commented
Nov 21, 2024
|
|
||
| return ( | ||
| <Animated.View | ||
| style={[pal.view, pal.border, styles.tabBar, headerMinimalShellTransform]} |
Contributor
Author
There was a problem hiding this comment.
this isn't needed because the stuff inside has its own backgrounds
| onLayout={e => { | ||
| headerHeight.set(e.nativeEvent.layout.height) | ||
| }}> | ||
| <View style={[pal.view, styles.topBar]}> |
| headerHeight.set(e.nativeEvent.layout.height) | ||
| }}> | ||
| <View style={[pal.view, styles.topBar]}> | ||
| <View style={[pal.view, {width: 100}]}> |
Contributor
Author
There was a problem hiding this comment.
not needed because of background above
| atoms.justify_end, | ||
| atoms.align_center, | ||
| atoms.gap_md, | ||
| pal.view, |
Contributor
Author
There was a problem hiding this comment.
not needed because of background above
|
|
||
| return ( | ||
| <> | ||
| <Animated.View style={[a.h_full]}> |
| } | ||
| }, [theme]) | ||
| return ( | ||
| <View testID="mobileShellView" style={[styles.outerContainer, pal.view]}> |
Contributor
Author
There was a problem hiding this comment.
not needed because all individual routes have contentStyle: t.atoms.bg
gaearon
requested review from
estrattonbailey,
haileyok,
mozzius and
pfrazee
Contributor
|
haileyok
approved these changes
Nov 21, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This probably isn't very important but I figured we might as well do it.
These don't need explicit backgrounds because there's a background above.
Test Plan
Walk around the screens, everything looks the same visually. The home/profile tabbar still has a solid background. Same for the bottom bar.
Before
After
(The bottom bar isn't actually transparent, it's just how "Debug GPU Overdraw" visualizes it.)