Fix embeder#6616
Merged
Merged
Conversation
arcalinea
temporarily deployed
to
unbr-embedder - social-app PR #6616
Render
Destroyed
gaearon
requested review from
estrattonbailey,
haileyok,
mozzius and
pfrazee
haileyok
approved these changes
Nov 21, 2024
estrattonbailey
approved these changes
Nov 21, 2024
Contributor
|
Contributor
|
Apologies, next time I will be more thorough in testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It got broken in #6591. For some reason the CI didn't run on the PR. On main it shows a type error. The fix is easy.
Test Plan
Read the code