Skip to content

Fix overflow issue on iOS autocomplete, among other things#6611

Merged
gaearon merged 5 commits into
mainfrom
samuel/improve-autocomplete
Nov 21, 2024
Merged

Fix overflow issue on iOS autocomplete, among other things#6611
gaearon merged 5 commits into
mainfrom
samuel/improve-autocomplete

Conversation

@mozzius
Copy link
Copy Markdown
Member

@mozzius mozzius commented Nov 21, 2024

Fixes a few issues with the autocomplete

  • Fixes overflow issue on iOS (ripped out a dumb system based on number of characters and just figured out how to do the same behaviour with flexbox)
  • Fixes missing display name issue on web (search for @zed.dev to see this)
  • Remove use of reading refs in render in favour of the built-in flag on the hook
  • Use unicode symbol for ellipsis instead of ... (since this looks weird next to numberOfLines)
Before After
Screenshot 2024-11-21 at 20 50 51 Screenshot 2024-11-21 at 20 49 29

Test plan

  • Check that the overflow issue is indeed fixed (iOS) and check that I didn't break anything (Android)
  • Check that it still maintains stale items as you type (this is what the ref did)
  • Check that accounts where the displayname is >50% width and handles are short still take up as much space as they can (iOS + Android) - @atproto.com is a good example

@mozzius mozzius requested a review from haileyok November 21, 2024 20:58
@arcalinea arcalinea temporarily deployed to samuel/improve-autocomplete - social-app PR #6611 November 21, 2024 20:58 — with Render Destroyed
@mozzius mozzius changed the title Fix overflow issue on iOS autocomplete Fix overflow issue on iOS autocomplete, among other things Nov 21, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 21, 2024

Old size New size Diff
8.06 MB 8.06 MB -1 B (-0.00%)

@arcalinea arcalinea temporarily deployed to samuel/improve-autocomplete - social-app PR #6611 November 21, 2024 21:05 — with Render Destroyed
Copy link
Copy Markdown
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well in my testing

@gaearon gaearon merged commit 9f1e648 into main Nov 21, 2024
@gaearon gaearon deleted the samuel/improve-autocomplete branch November 21, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants