Disable vertical scrollbars on Android only#6586
Merged
Merged
Conversation
arcalinea
temporarily deployed
to
noscrollbar-android - social-app PR #6586
Render
Destroyed
gaearon
requested review from
estrattonbailey,
haileyok,
mozzius and
pfrazee
Contributor
|
estrattonbailey
approved these changes
Nov 21, 2024
mozzius
approved these changes
Nov 21, 2024
Member
mozzius
left a comment
mozzius
left a comment
There was a problem hiding this comment.
I'm fine with this
Not tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revisiting #3855 for two reasons:
hide_vertical_scrollbarstest #3855 doesn't applySo let's remove them but on Android only.
Test Plan
Can still see them on iOS and web. Can't see them on Android.