Prevent <ProfileHeaderHandle /> from breaking out of its parent view#6574
Merged
mozzius merged 1 commit intoNov 20, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes?
Sets a max width of 100% for the
ProfileHeaderHandlecomponent to prevent it from overflowing in views like Settings.Fixes #6569.
How to test
The easiest way is to clone the branch, replace this line with a very long handle and visualize the changes:
https://github.com/HorusGoul/bsky-social-app/blob/a7aaeaec11dba45d1c1654b2cd6c5ed344d669bc/src/screens/Profile/Header/Handle.tsx#L52
I used this handle:
@verylonghandlewithsomanycharacters.thatitmightbreaktheblueskyimplementationforhandles.orletsseehowthisshowsupintheuilol.hibtwandimsosorry.therearestillsomanymorecharacterstofillidk.imightaswellgototwohundredorsomethinglikethat.bye.horus.devScreenshot showing the fix
The issue seems to be present on Web but not on Android. I can't check iOS at the moment.
Testing for both short and long handles:
Settings:


Profile:


Labeler profile:

