Skip to content

Use outline style for repost cancel button#6509

Merged
gaearon merged 2 commits into
mainfrom
samuel/repost-cancel-btn
Nov 22, 2024
Merged

Use outline style for repost cancel button#6509
gaearon merged 2 commits into
mainfrom
samuel/repost-cancel-btn

Conversation

@mozzius
Copy link
Copy Markdown
Member

@mozzius mozzius commented Nov 18, 2024

I think it looks nicer, feel free to disagree

Also took the opportunity to use <Trans> rather than _(msg) in JSX, since this is inconsistent with the rest of the codebase

Screenshot 2024-11-18 at 21 42 54

@arcalinea arcalinea temporarily deployed to samuel/repost-cancel-btn - social-app PR #6509 November 18, 2024 21:43 — with Render Destroyed
@github-actions
Copy link
Copy Markdown
Contributor

Old size New size Diff
8.05 MB 8.05 MB 0 B (0.00%)

@mozzius mozzius force-pushed the samuel/repost-cancel-btn branch from 67e7c85 to 077f922 Compare November 18, 2024 21:55
@arcalinea arcalinea temporarily deployed to samuel/repost-cancel-btn - social-app PR #6509 November 18, 2024 21:55 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/repost-cancel-btn - social-app PR #6509 November 18, 2024 21:55 — with Render Destroyed
Copy link
Copy Markdown
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@gaearon gaearon merged commit a5dbb35 into main Nov 22, 2024
@mozzius mozzius deleted the samuel/repost-cancel-btn branch June 10, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants