fix: Translate button sends users to homepage#6289
Conversation
|
where is that # coming from? we should remove it there instead. |
Ah, my bad - didn't realise there was already a way to handle this in there. |
|
I recently found that this issue isn’t limited to the web platform—it can occur across all platforms, including iOS. To be honest, it’s a bit annoying. |
|
@gaearon Sorry to bother you, could you take another look at this PR? |
|
I believe there might've been an attempt to fix this - folks are reporting this as still an issue in 1.94 but more inconsistently. I think the version @gaearon came up with (implemented in this PR) might work the best, as I've not been able to replicate with it. |
|
Just wondering, is this ready to merge? There's a message saying that this branch has conflicts 🤔 |
I'll quickly fix the conflict so that it's not there but I suspect the solution will literally just be deleting what's there unfortunately, not sure if the maintainers can do a force merge w/ this version 🤷🏻 |
|
Closed based on @auroursa fix above being merged. |
Fixes: #6287
Why
As reported by @auroursa, the translate button on extended posts will send the user to the homepage unintentionally
See behaviour here: https://bsky.app/profile/youareexisting.bsky.social/post/3lasuvhylqk2j