Skip to content

fix: Translate button sends users to homepage#6289

Closed
O4FDev wants to merge 4 commits into
bluesky-social:mainfrom
O4FDev:fix/6287/blank-link
Closed

fix: Translate button sends users to homepage#6289
O4FDev wants to merge 4 commits into
bluesky-social:mainfrom
O4FDev:fix/6287/blank-link

Conversation

@O4FDev
Copy link
Copy Markdown
Contributor

@O4FDev O4FDev commented Nov 13, 2024

Fixes: #6287

Why

As reported by @auroursa, the translate button on extended posts will send the user to the homepage unintentionally
See behaviour here: https://bsky.app/profile/youareexisting.bsky.social/post/3lasuvhylqk2j

@gaearon
Copy link
Copy Markdown
Contributor

gaearon commented Nov 13, 2024

where is that # coming from? we should remove it there instead.

@O4FDev
Copy link
Copy Markdown
Contributor Author

O4FDev commented Nov 13, 2024

where is that # coming from? we should remove it there instead.

Ah, my bad - didn't realise there was already a way to handle this in there.
Done

@O4FDev O4FDev changed the title fix: # url sends users to homepage fix: Translate button sends users to homepage Nov 13, 2024
Comment thread src/view/com/post-thread/PostThreadItem.tsx
@auroursa
Copy link
Copy Markdown
Contributor

I recently found that this issue isn’t limited to the web platform—it can occur across all platforms, including iOS. To be honest, it’s a bit annoying.

@auroursa
Copy link
Copy Markdown
Contributor

@gaearon Sorry to bother you, could you take another look at this PR?

@O4FDev
Copy link
Copy Markdown
Contributor Author

O4FDev commented Nov 20, 2024

I believe there might've been an attempt to fix this - folks are reporting this as still an issue in 1.94 but more inconsistently. I think the version @gaearon came up with (implemented in this PR) might work the best, as I've not been able to replicate with it.

@surfdude29
Copy link
Copy Markdown
Contributor

Just wondering, is this ready to merge? There's a message saying that this branch has conflicts 🤔

@O4FDev
Copy link
Copy Markdown
Contributor Author

O4FDev commented Nov 20, 2024

Just wondering, is this ready to merge? There's a message saying that this branch has conflicts 🤔

I'll quickly fix the conflict so that it's not there but I suspect the solution will literally just be deleting what's there unfortunately, not sure if the maintainers can do a force merge w/ this version 🤷🏻

@O4FDev
Copy link
Copy Markdown
Contributor Author

O4FDev commented Nov 23, 2024

Closed based on @auroursa fix above being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After clicking the 'Translate' button, Bluesky will returns to the home page

4 participants