Fix starter pack profiles list being cut off#6152
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5961
Summary
The issue was the profiles list being cut off on some devices with specific starter packs. Actually, It is not specific to the devices, but it occurs whenever the starter pack header section is tall enough. So, in the current code, the bottom padding of the list is derived from an arbitrary number (300), which means it can be either bigger or smaller than necessary.
Solution
I updated the code so that the bottom padding is derived from the header height rather than an arbitrary number like 300. This ensures that the profiles list always has a consistent bottom space across all devices(30px).
Before
Android -
android-before.webm
iOS -
https://github.com/user-attachments/assets/3560756d-a6a4-4aea-a754-b8e4e99c0e5b
After
Android -
android-after.webm
iOS -
https://github.com/user-attachments/assets/b92fa574-5d93-4e2b-bc3c-b882a1ce9f91