Add ability to block account from post dropdown menu#6091
Merged
haileyok merged 7 commits intoNov 22, 2024
Conversation
|
Yes! Please add this. I was just about to make an issue for this. This makes blocking have less friction and makes the UX much better, especially in terms of a11y. In addition, being able to easily add to a moderation list from the same menu would be great. |
rshigg
force-pushed
the
block-account-from-post-dropdown
branch
from
c53a92a to
1614df3
Compare
haileyok
reviewed
Nov 22, 2024
haileyok
approved these changes
Nov 22, 2024
Member
haileyok
left a comment
haileyok
left a comment
There was a problem hiding this comment.
Nice! I made a small change to use useProfileShadow and just use ProfileViewBasic in the profile arg type (since all we ever need from the profile is did and viewer, which is available in all of the ProfileViewX types), no need for the Pick.
Really appreciate this one, been something on the todos for a while and just never had time to do it.
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
While #3708 already exists, it hasn't been updated sine April and I personally don't think including the mute option is necessary. If it is decided that a mute button is needed/wanted, I can update this PR or I could open a separate PR.
Note: I don't consider this PR complete since I assume we will want some sort of visual feedback that a user was blocked while in a feed. My initial thinking was to hide the post after blocking but it felt a little janky. I would appreciate some feedback.
Demo
(Sorry Abby and Jerry, it's not personal 😅 )
block_from_feed.webm
block_from_profile.webm
Screen.Recording.2024-11-03.at.12.34.53.PM.mov
Screen.Recording.2024-11-03.at.12.35.13.PM.mov