Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Video] Fix scrubber tap target #5360

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[Video] Fix scrubber tap target #5360

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b24dd1
put padding on correct element
mozzius Sep 16, 2024
e191cdd
clear timeout on down
mozzius Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/view/com/util/post-embeds/VideoEmbedInner/VideoWebControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ export function Controls({
if (evt.pointerType !== 'mouse' && !hovered) {
evt.preventDefault()
}
clearTimeout(timeoutRef.current)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is supposed to be here right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

},
[hovered],
)
Expand Down Expand Up @@ -355,7 +356,7 @@ export function Controls({
style={[
a.flex_1,
a.px_xs,
a.pt_sm,
a.pt_2xs,
a.pb_md,
a.gap_md,
a.flex_row,
Expand Down Expand Up @@ -592,7 +593,7 @@ function Scrubber({
return (
<View
testID="scrubber"
style={[{height: 18, width: '100%'}, a.flex_shrink_0, a.px_xs, a.py_xs]}
style={[{height: 18, width: '100%'}, a.flex_shrink_0, a.px_xs]}
onPointerEnter={onStartHover}
onPointerLeave={onEndHover}>
<div
Expand All @@ -603,6 +604,7 @@ function Scrubber({
alignItems: 'center',
position: 'relative',
cursor: scrubberActive ? 'grabbing' : 'grab',
padding: '4px 0',
}}
onPointerDown={onPointerDown}
onPointerMove={onPointerMove}
Expand Down
Loading