Don't use mask for android at all #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrazee
approved these changes
Jan 8, 2024
estrattonbailey
added a commit
that referenced
this pull request
Jan 8, 2024
* origin: (45 commits) Fix splash config (#2452) convert prefix to lowercase in actor autocomplete query (#2431) support intl tenor links (#2438) Splash: reduce motion + dark mode (#2448) Bump android app version code Don't use mask for android at all (#2445) Update Korean localization (#2432) Use android mode, fix fallback (#2437) Update for Version 1.63 Português (BR) (#2435) New translations messages.po (Ukrainian) (#2422) Update Japanese localization (addition + language code correction) (#2423) 1.63 Additional embed sources and external-media consent controls (#2424) Reduce web requests (#2420) New user home feed fixes (#2421) E2E runner fixes (#2428) Recompile all locales (#2411) (#2416) Add Ukrainian localization (#2336) Update Portuguese for Português (#2414) Add Portuguese Localization (#2407) ...
pull bot
pushed a commit
to imax9000/bsky-app-ua
that referenced
this pull request
Jan 12, 2024
* Don't use mask for android at all * Remove old Android check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abandons the mask in Android entirely. I tweaked the animation speed a bit to look better without the mask, looks good with mask (iOS) too.
Android:
screen-20240108-113433.mp4
iOS:
Simulator.Screen.Recording.-.iPhone.15.-.2024-01-08.at.11.36.13.mp4