Skip to content

Commit

Permalink
Revert "Fix notification scroll jump (#5297)"
Browse files Browse the repository at this point in the history
This reverts commit e0d9e75.
  • Loading branch information
gaearon committed Sep 13, 2024
1 parent fddb125 commit dfa50e5
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions src/state/queries/notifications/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,19 +175,9 @@ async function fetchSubjects(
}> {
const postUris = new Set<string>()
const packUris = new Set<string>()

const postUrisWithLikes = new Set<string>()
const postUrisWithReposts = new Set<string>()

for (const notif of groupedNotifs) {
if (notif.subjectUri?.includes('app.bsky.feed.post')) {
postUris.add(notif.subjectUri)
if (notif.type === 'post-like') {
postUrisWithLikes.add(notif.subjectUri)
}
if (notif.type === 'repost') {
postUrisWithReposts.add(notif.subjectUri)
}
} else if (
notif.notification.reasonSubject?.includes('app.bsky.graph.starterpack')
) {
Expand Down Expand Up @@ -216,15 +206,6 @@ async function fetchSubjects(
AppBskyFeedPost.validateRecord(post.record).success
) {
postsMap.set(post.uri, post)

// HACK. In some cases, the appview appears to lag behind and returns empty counters.
// To prevent scroll jump due to missing metrics, fill in 1 like/repost instead of 0.
if (post.likeCount === 0 && postUrisWithLikes.has(post.uri)) {
post.likeCount = 1
}
if (post.repostCount === 0 && postUrisWithReposts.has(post.uri)) {
post.repostCount = 1
}
}
}
for (const pack of packsChunks.flat()) {
Expand Down

0 comments on commit dfa50e5

Please sign in to comment.