Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isFallback to getSuggestedFollowsByActor method #2805

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Sep 9, 2024

We want to know on the client if the results from this endpoint are actually specific to the actor we passed in as relativeToDid or not. This endpoint is used on Profile screens and nowhere else.

Inferred based on returned `relativeToDid` from the suggestions
response.
Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good besides the note about maybe switching isFallback to isPersonalized

@estrattonbailey estrattonbailey merged commit 319aa7c into main Sep 13, 2024
10 checks passed
@estrattonbailey estrattonbailey deleted the suggestions-fallback branch September 13, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants