Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

630 - Add media type payload unassigned number 35 in format #632

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

JTejedor
Copy link
Contributor

@JTejedor JTejedor commented Oct 9, 2024

Media type payload unassigned number 35 is being evaluated as media type payload dynamic range (96-127). Added some tests to verify these new changes on format_test

Currently, the video surveillance cameras of the bosch security branch offer rtsp with some peculiarities over the standard.
Instead of using the convenience media payload, which is usually 96, they use 35. This means that the camera format is not detected correctly.
This happens at least for the model FLEXIDOME IP starlight 8000i - 7.62.0003 (03500762)
There is an initial note on the first page of the document (manual) on how to use RTSP protocol in Bosch VIP cameras where it is specified that they use payload type 35 (https://community.boschsecurity.com/varuj77995/attachments/varuj77995/bt_community-tkb-video/241/1/RTSP%20usage%20with%20Bosch%20Video%20IP%20Devices.pdf).

The two examples of SDP extracted from the camera are:

  • SDP Just h264
v=0
o=- 0 0 IN IP4 10.100.14.102
s=LIVE VIEW
c=IN IP4 0.0.0.0
t=0 0
a=control:rtsp://10.100.14.102:554/?inst=2&h26x=4
m=video 0 RTP/AVP 35
a=rtpmap:35 H264/90000
a=control:rtsp://10.100.14.102:554/?inst=2&h26x=4&stream=video
a=recvonly
a=fmtp:35 packetization-mode=1;profile-level-id=4d4029;sprop-parameter-sets=Z01AKY2NYDwBE/LgLcBDQECA,aO44gA==
  • SDP for h264 and h265
v=0
o=- 0 0 IN IP4 10.100.14.102
s=LIVE VIEW
c=IN IP4 0.0.0.0
t=0 0
a=control:rtsp://10.100.14.102:554/?inst=1
m=video 0 RTP/AVP 35
a=rtpmap:35 H264/90000
a=rtpmap:102 H265/90000
a=control:rtsp://10.100.14.102:554/?inst=1&stream=video
a=recvonly
a=fmtp:35 packetization-mode=1;profile-level-id=4d4033;sprop-parameter-sets=Z01AM42NYB4AIfYC3AQ0BAg=,aO44gA==

Note: We already have some test on sdp_test.go with these examples but they are not uploaded, you may require them if you like

@JTejedor JTejedor force-pushed the 630-bosch-dsp-media-payload branch from a5d0939 to 33aa7a3 Compare October 10, 2024 07:03
@JTejedor JTejedor marked this pull request as ready for review October 10, 2024 08:18
@aler9
Copy link
Member

aler9 commented Oct 11, 2024

Hello, this is OK, but can you restrict the payload type to just 35 instead of the interval between 35 and 71? until now there's not reason to consider 36-71. If we find a reason, we will add it (together with a reference, like you did with the Bosh document). Thanks.

@JTejedor JTejedor force-pushed the 630-bosch-dsp-media-payload branch from 33aa7a3 to 3259ab8 Compare October 14, 2024 07:58
@JTejedor JTejedor changed the title 630 - Add media type payload unassigned interval 35 to 71 in format 630 - Add media type payload unassigned number 35 in format Oct 14, 2024
@JTejedor
Copy link
Contributor Author

Hello, the changes have been made as you requested, only the media type 35 has been considered. The tests are still passing. Thank you very much for everything

Add some test to make sure the unassigned 35 media type is being considered
@JTejedor JTejedor force-pushed the 630-bosch-dsp-media-payload branch from 3259ab8 to fdf597b Compare October 14, 2024 09:57
@aler9 aler9 force-pushed the 630-bosch-dsp-media-payload branch from 7f8c963 to d452a89 Compare October 14, 2024 10:01
@aler9 aler9 force-pushed the 630-bosch-dsp-media-payload branch from d452a89 to eba5782 Compare October 14, 2024 10:03
@aler9 aler9 merged commit b561229 into bluenviron:main Oct 14, 2024
7 checks passed
@aler9
Copy link
Member

aler9 commented Oct 14, 2024

i restricted payload type 35 to H264 and merged. Thanks.

@JTejedor
Copy link
Contributor Author

Thanks for merge and sorry we didn't get exactly what you requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants