Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors are dropped getting dropped here:
gortsplib/client_media.go
Line 169 in c465264
and we would like to keep track of errors.
We want to track errors because in some cases, when device network connectivity changes, we see situations where gortsplib client keeps a connection still open, while the gortsplib server has already closed the connection. In these situations all packet writes result in an error. Exposing an error count seems like the simplest solution to detect and act on these situations.