Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AudioElement is not getting released correctly #1516

Merged
merged 4 commits into from
May 23, 2023
Merged

fix: AudioElement is not getting released correctly #1516

merged 4 commits into from
May 23, 2023

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented May 23, 2023 •
edited by Gustl22
Loading

Description

Implement correct AudioElement releasing as mentioned in the #966

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Resolves #966

@Gustl22
Copy link
Collaborator

Gustl22 commented May 23, 2023

Thank you 🎉 ! As tests may not practicable here, you may add a comment and link the issue #966 in the code to avoid reverting the fix ;D

@Gustl22 Gustl22 merged commit 32210f3 into bluefireteam:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustl22 Gustl22 Gustl22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web, Chrome 92] AudioElement is not getting disposed correctly
2 participants
@krida2000 @Gustl22