Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): emit onPositionChanged when seek is completed (closes #1259) #1265

Merged
merged 1 commit into from
Sep 2, 2022
Merged

fix(android): emit onPositionChanged when seek is completed (closes #1259) #1265

merged 1 commit into from
Sep 2, 2022

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Aug 31, 2022

Description

Android: emits onPositionChanged event, when seek is completed.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Closes #1259

@Gustl22 Gustl22 requested review from spydon and luanpotter August 31, 2022 13:22
spydon
spydon approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Base automatically changed from chore/flutter-3.3.0 to main September 1, 2022 23:02
@Gustl22 Gustl22 force-pushed the bug/1259-android-seek-position branch from e1adfe3 to 6e79236 Compare September 2, 2022 00:17
@Gustl22 Gustl22 marked this pull request as ready for review September 2, 2022 00:18
@Gustl22 Gustl22 merged commit be7ac6a into main Sep 2, 2022
@Gustl22 Gustl22 deleted the bug/1259-android-seek-position branch September 2, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@luanpotter luanpotter Awaiting requested review from luanpotter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android: Seeking while audio is in the paused state doesn't invoke onPositionChanged listeners
2 participants
@Gustl22 @spydon