Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setPlaybackRate misfunction #468

Closed
RaistlinTAO opened this issue Mar 25, 2020 · 2 comments · Fixed by #1658
Closed

setPlaybackRate misfunction #468

RaistlinTAO opened this issue Mar 25, 2020 · 2 comments · Fixed by #1658
Labels
bug platform-ios Affects the ios platform reproducible Bug can be reproduced

Comments

@RaistlinTAO
Copy link

RaistlinTAO commented Mar 25, 2020

EVERYTHING IN FLUTTER DOCTOR IS OK

Steps to reproduce:

1. Set the button:

FlatButton(
                onPressed: () {
                  advancedPlayer.setPlaybackRate(playbackRate: 1.2);
                },
                child: Text(
                  "X1.2",
                  style: TextStyle(fontSize: 15.0),
                ),
              ),

2. A listener on PlayerStateChanged

 advancedPlayer.onPlayerStateChanged
        .listen((AudioPlayerState s) => {setState(() => status.value = s)});

3. Call Pause() to pause the playing (AudioPlayerState = PAUSED)

4. Click the rate button (Audio is start playing but the AudioPlayerState still eqs to PAUSED)

Result:

The setPlaybackRate applied succesfuly, but the AudioPlayerState still unchanged.

Expectation:

The setPlaybackRate should not start playing a paused audio.

If AudioPlayer is Playing, it should applies the rate and keep playing
If AudioPlayer is Paused or Stopped, it should applies the rate setting but Not start playing the audio.
If by design the setPlaybackRate function will start playing a paused audio, it should also change the AudioPlayerState = Playing

@luanpotter
Copy link
Member

This is indeed a bug, when converting the code to swift I also noticed this.

@luanpotter luanpotter added the bug label Nov 22, 2020
@Gustl22 Gustl22 added the platform-ios Affects the ios platform label Sep 3, 2022
@Gustl22
Copy link
Collaborator

Gustl22 commented Sep 3, 2022

@RaistlinTAO Can you check, is this still a thing with 1.x.x? Thx :) I cannot test for ios, unfortunately.

@Gustl22 Gustl22 added the waiting for report Wait for the author to respond to the conversation label Sep 3, 2022
@Gustl22 Gustl22 added reproducible Bug can be reproduced and removed waiting for report Wait for the author to respond to the conversation labels Oct 1, 2023
Gustl22 added a commit that referenced this issue Oct 1, 2023
Gustl22 added a commit that referenced this issue Oct 1, 2023
Gustl22 added a commit that referenced this issue Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug platform-ios Affects the ios platform reproducible Bug can be reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants