Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Release source for Web, Linux, Windows #1517

Merged
merged 13 commits into from
Aug 18, 2023
Merged

feat: Release source for Web, Linux, Windows #1517

merged 13 commits into from
Aug 18, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented May 23, 2023 •
edited
Loading

Description

Player should:

  • release resources in Release mode, when stop is called This is not expected, as ReleaseMode only is referred to, when the source is played to the end.
  • release resources in Release mode, when source is completed
  • resume from 0 after release and setting new source, if previously was playing

Checklist

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Closes #1537

@Gustl22 Gustl22 mentioned this pull request Jun 12, 2023
Closed
2 tasks
@Gustl22 Gustl22 changed the title fix: harmonize release & release mode feat: release source for Web, Linux, Windows Aug 17, 2023
@Gustl22 Gustl22 marked this pull request as ready for review August 17, 2023 15:27
@Gustl22 Gustl22 requested a review from spydon August 17, 2023 15:27
@Gustl22 Gustl22 changed the title feat: release source for Web, Linux, Windows feat: Release source for Web, Linux, Windows Aug 17, 2023
@Gustl22 Gustl22 requested review from spydon and removed request for spydon August 18, 2023 10:28
@Gustl22 Gustl22 merged commit 09496dc into main Aug 18, 2023
@Gustl22 Gustl22 deleted the gustl22/resume-release branch August 18, 2023 11:13
Gustl22 added a commit that referenced this pull request Sep 26, 2023
@Gustl22
feat: Release source for Web, Linux, Windows (#1517)
3f3f435 
# Description

Release sources in `Release` mode, when source is `completed`.

## Related Issues

Closes #1537

(cherry picked from commit 09496dc)
Gustl22 added a commit that referenced this pull request Nov 14, 2023
@Gustl22
feat: Release source for Web, Linux, Windows (#1517)
c666217 
# Description

Release sources in `Release` mode, when source is `completed`.

## Related Issues

Closes #1537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Windows] File is never closed
2 participants
@Gustl22 @spydon