ci: Upgrade to Flutter v3.24.x (#1858)

bluefireteam · Nov 18, 2024 · 743f04b · 743f04b
1 parent 01726c1
commit 743f04b
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 47 deletions.
diff --git a/.github/workflows/build-example.yml b/.github/workflows/build-example.yml
@@ -9,8 +9,8 @@ on:
         type: choice
         options:
           - 'any'
+          - '3.24.x'
           - '3.22.x'
-          - '3.19.x'
       flutter_channel:
         description: 'Flutter Channel'
         required: false
@@ -60,7 +60,7 @@ on:
     inputs:
       flutter_version:
         required: false
-        default: '3.22.3'
+        default: '3.24.5'
         type: string
       flutter_channel:
         required: false
@@ -111,24 +111,6 @@ jobs:
       - name: Example app - Build Web app
         working-directory: ./packages/audioplayers/example
         run: flutter build web
-      - name: Upload pages artifact
-        if: inputs.upload_pages_artifact
-        uses: actions/upload-pages-artifact@v2
-        with:
-          path: ./packages/audioplayers/example/build/web
-
-  # TODO(gustl22): Remove, when min supported flutter version is 3.22.x, so can integrate wasm test in the default 'web' build.
-  web-wasm:
-    runs-on: ubuntu-latest
-    timeout-minutes: 30
-    if: inputs.enable_web
-    steps:
-      - uses: actions/checkout@v4
-      - uses: subosito/flutter-action@v2
-        with:
-          flutter-version: 3.22.3
-      - uses: bluefireteam/melos-action@main
-
       - name: Example app - Build Web app in WASM
         working-directory: ./packages/audioplayers/example
         run: flutter build web --wasm

diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -8,6 +8,17 @@ on:
       - ready_for_review
 
 jobs:
+  call-min-flutter-test:
+    uses: ./.github/workflows/test.yml
+    with:
+      flutter_version: '3.22.0'
+      fatal_warnings: false
+      enable_android: ${{ github.event.pull_request.draft == false }}
+      enable_web: ${{ github.event.pull_request.draft == false }}
+      enable_ios: ${{ github.event.pull_request.draft == false }}
+      enable_windows: ${{ github.event.pull_request.draft == false }}
+      enable_linux: ${{ github.event.pull_request.draft == false }}
+      enable_macos: ${{ github.event.pull_request.draft == false }}
   call-test:
     uses: ./.github/workflows/test.yml
     with:

diff --git a/.github/workflows/release-prepare.yml b/.github/workflows/release-prepare.yml
@@ -9,14 +9,8 @@ on:
         type: boolean
 
 jobs:
-  call-min-flutter-test:
-    uses: ./.github/workflows/test.yml
-    with:
-      flutter_version: '3.22.0'
-      fatal_warnings: false
   prepare-release:
     name: Prepare release
-    needs: call-min-flutter-test
     permissions:
       contents: write
       pull-requests: write

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -9,8 +9,8 @@ on:
         type: choice
         options:
           - 'any'
+          - '3.24.x'
           - '3.22.x'
-          - '3.19.x'
       flutter_channel:
         description: 'Flutter Channel'
         required: false
@@ -60,7 +60,7 @@ on:
     inputs:
       flutter_version:
         required: false
-        default: '3.22.3'
+        default: '3.24.5'
         type: string
       flutter_channel:
         required: false

diff --git a/packages/audioplayers/example/lib/generated_plugin_registrant.dart b/packages/audioplayers/example/lib/generated_plugin_registrant.dart