-
Notifications
You must be signed in to change notification settings - Fork 853
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(ios)!: Improve AudioContextIOS (#1591)
# Description - Add assertions for AudioContextIOS - Convert AudioContextIOS.options from List to Set Closes #1584 ## Breaking Change ### Migration instructions Before: ```dart const AudioContext(); const AudioContextIOS(); AudioContextIOS(options: [ /* ... */ ]); ``` After: ```dart AudioContext(); AudioContextIOS(); AudioContextIOS(options: { /* ... */ }); ``` ## Related Issues Closes #1584
- Loading branch information
Showing
7 changed files
with
240 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
packages/audioplayers_platform_interface/test/audio_context_test.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
//ignore_for_file: avoid_redundant_argument_values | ||
|
||
import 'package:audioplayers_platform_interface/audioplayers_platform_interface.dart'; | ||
import 'package:flutter_test/flutter_test.dart'; | ||
|
||
void main() { | ||
TestWidgetsFlutterBinding.ensureInitialized(); | ||
|
||
test('Create default AudioContext', () async { | ||
final context = AudioContext(); | ||
expect( | ||
context, | ||
AudioContext( | ||
android: const AudioContextAndroid( | ||
isSpeakerphoneOn: false, | ||
audioMode: AndroidAudioMode.normal, | ||
stayAwake: false, | ||
contentType: AndroidContentType.music, | ||
usageType: AndroidUsageType.media, | ||
audioFocus: AndroidAudioFocus.gain, | ||
), | ||
iOS: AudioContextIOS( | ||
category: AVAudioSessionCategory.playback, | ||
options: const {}, | ||
), | ||
), | ||
); | ||
}); | ||
|
||
test('Create invalid AudioContextIOS', () async { | ||
try { | ||
// Throws AssertionError: | ||
AudioContextIOS( | ||
category: AVAudioSessionCategory.ambient, | ||
options: const {AVAudioSessionOptions.mixWithOthers}, | ||
); | ||
fail('AssertionError not thrown'); | ||
// ignore: avoid_catches_without_on_clauses | ||
} catch (e) { | ||
expect(e, isInstanceOf<AssertionError>()); | ||
expect( | ||
(e as AssertionError).message, | ||
'You can set the option `mixWithOthers` explicitly only if the audio ' | ||
'session category is `playAndRecord`, `playback`, or `multiRoute`.'); | ||
} | ||
}); | ||
|
||
test('Equality of AudioContextIOS', () async { | ||
final context1 = AudioContextIOS( | ||
category: AVAudioSessionCategory.playAndRecord, | ||
options: const { | ||
AVAudioSessionOptions.mixWithOthers, | ||
AVAudioSessionOptions.defaultToSpeaker, | ||
}, | ||
); | ||
final context2 = AudioContextIOS( | ||
category: AVAudioSessionCategory.playAndRecord, | ||
options: const { | ||
AVAudioSessionOptions.defaultToSpeaker, | ||
AVAudioSessionOptions.mixWithOthers, | ||
}, | ||
); | ||
expect(context1, context2); | ||
}); | ||
} |
Oops, something went wrong.