Skip to content

Set custom attributes + add test. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2017
Merged

Set custom attributes + add test. #10

merged 2 commits into from
Jul 9, 2017

Conversation

julesterrien
Copy link
Contributor

@julesterrien julesterrien commented Jul 9, 2017 •
edited
Loading

This PR:

  • sets custom attributes passed as props on the script tag
  • includes a test
  • adds the attribute prop to the README

Feedback is always welcome if there's anything you would do differently

@julesterrien julesterrien mentioned this pull request Jul 9, 2017
Closed
@jakubkottnauer
Copy link
Contributor

This is great, thanks!

@jakubkottnauer jakubkottnauer merged commit 696489e into blueberryapps:master Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@julesterrien @jakubkottnauer