-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Carthage support and upgraded to Swift 4 #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Carthage support looks great 👍. However, the sample project doesn't build anymore. We'll need to fix that and also verify that CocoaPods integration is still all good (I didn't test this yet, could be a non-issue).
Nice catch, will fix that over the weekend and I'll also verify that Cocoapods integration still works. |
@huebnerob I was looking into this issue over the weekend and I was having trouble getting the tests to pass, even by checking out the vanilla The test Example project needs to be built against Swift 4.0 and have its 3rd party dependencies updated. Unfortunately, I don't have much time to work on this. If someone is willing to jump in and update this PR, I'd be more than happy. Otherwise, I can close this PR and keep working from my fork 😕 |
Ah, alright, sorry this is more complex than expected. I will have some time to look into it tomorrow and I will report back. |
@huebnerob Thank you for taking the time for this one! Don't worry about unblocking me, I've since worked off of my own fork, but wanted to contribute back with this PR. I'll rebase this PR onto #9 and go from there. Sidenote: I'll be afk for a few days so feel free to take over if needed. |
@gapl Great, thanks for your contributions! I'll continue to work on getting the |
Description
After merge
Please tag this as a stable release on GitHub so Carthage will be able to find it. Carthage determines which versions of framework are available by searching through the tags published on the repository, and trying to interpret each tag name as a semantic version. For example, in the tag v1.2, the semantic version is 1.2.0.