Conversation
Member
Author
|
@DaniPopes can you review this one when you have time? |
Rjected
approved these changes
Oct 12, 2023
Collaborator
Rjected
left a comment
Rjected
left a comment
There was a problem hiding this comment.
lgtm, the slicing and padding can be a bit confusing but the implementation seems as simple as it can be
DaniPopes
approved these changes
Oct 12, 2023
Collaborator
DaniPopes
left a comment
DaniPopes
left a comment
There was a problem hiding this comment.
Sorry did not see this. LGTM
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
3 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor modexp input parsing and use aurora modexp lib.
Blocked on aurora-is-near/aurora-engine#844