Conversation
mattsse
approved these changes
Sep 29, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm,
some derives like hash may not be needed but can't hurt
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
rakita
reviewed
Oct 3, 2023
|
|
||
| /// The EVM stack limit, in number of items. | ||
| pub const STACK_LIMIT: usize = 1024; | ||
| const STACK_LIMIT: usize = 1024; |
Member
There was a problem hiding this comment.
Leave it as a pub, it does not hurt
rakita
reviewed
Oct 3, 2023
| #![warn(missing_debug_implementations, unreachable_pub)] | ||
| #![deny(unused_must_use, rust_2018_idioms)] | ||
| #![cfg_attr(not(feature = "std"), no_std)] | ||
| #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))] |
rakita
reviewed
Oct 3, 2023
| /// | ||
| /// Note: It is marked as Send so database can be shared between threads. | ||
| pub database: DB, //Box<dyn Database<Error = DBError> + Send + 'a>, | ||
| pub database: DB, |
Member
|
@DaniPopes if you are okay, would take this over |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.