Merged
Conversation
CfgEnv.chain_id should be u64
Collaborator
|
hm actually i realized this is wrong, realistically chain id is a u64 but users should be able to set any arbitrary u256 in the EVM |
Member
This is one of those ambiguous things where the upper limit was not specified but all the "chains" use u64, so it is a good call to use u64. Here is a site that lists chain ids: https://chainlist.org/ |
Collaborator
|
Makes sense, this is also enforced in Foundry: |
mikelodder7
pushed a commit
to LIT-Protocol/revm
that referenced
this pull request
Sep 12, 2023
Evalir
pushed a commit
to Evalir/revm
that referenced
this pull request
Sep 14, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #671. Let me know if I am missing something from this issue!