feat: Add initcode limit to be double of bytecode limit#491
Merged
rakita merged 1 commit intorelease/v25from May 25, 2023
Merged
feat: Add initcode limit to be double of bytecode limit#491rakita merged 1 commit intorelease/v25from
rakita merged 1 commit intorelease/v25from
Conversation
mattsse
approved these changes
May 25, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
I guess that makes sense,
this would also prevent a breaking issue
Member
Author
This looks a little bit nicer to me, but if needed we can add an additional limit. |
rakita
added a commit
that referenced
this pull request
Aug 8, 2023
* wip separate initial checks * tests passing, consolidate some checks * test * feat: add transfer test * temp * Update crates/interpreter/src/gas/calc.rs * / Initial gas that is deducted from the transaction gas limit. * fmt * account states * temp * Global account BlockState. wip * few comments * wip * Tests working * wip changes * work on update and revert * AccountState as a simple enum flag * Add storage for EmptyEip161 account * split state to component files * continue spliting, wip State * feat: Add initcode limit to be double of bytecode limit (#491) * bigger cleanup, structure it * wip reverts and the flow * increments balance and some wip on reverts * feat: Run CI on release branches (#506) * feat: Add initcode limit to be double of bytecode limit (#503) * chore: Move Precompiles to EVMData so Inspector can access it (#504) * fix previous commit (#507) * wip cache account, changeset and revert * plain state wip, reverts compiles now * working changes * working and, added timestamps and println * Add reverts * clippy happy, some cleanup, work on reverts * wip on spliting and creating BundleState * needed things for integration * Few utilities, emptydb with typed error * wip * fix some things * cleanup * refactoring * clippy and some cleanup * add state clear flag * bugs fixes * add state builder * some cleanup and being more strict * cleanup, and simplification * check nonce for account * make storage was_destroyed * dont store storage when not needed * dont ask db for destroyed accounts * debug logs * test account * more debug * save previous state on double touch * check if pre eip161 touched account is already empty * Changr address * diferent debug account * set wipe flag for destroyed * remove some test clones * nit * clippy * make state behind std * lto * cleanup * set bigger stack size in tests * fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set initcode limit from EIP-3860 to be double of ma bytecode size if custom max bytecode size is set inside
env.cfg.limit_contract_code_size.