Skip to content

refactor!: add logs to Revert and Halt variants of ExecutionResult#3424

Merged
rakita merged 3 commits intomainfrom
logs
Feb 13, 2026
Merged

refactor!: add logs to Revert and Halt variants of ExecutionResult#3424
rakita merged 3 commits intomainfrom
logs

Conversation

@rakita
Copy link
Member

@rakita rakita commented Feb 12, 2026

Summary

  • Adds logs: Vec<Log> field to ExecutionResult::Revert (between gas and output) and ExecutionResult::Halt (after gas)
  • Logs emitted before a revert or halt were previously discarded; they are now preserved for downstream consumers
  • Updates logs() / into_logs() to return logs from all three variants, not just Success

Test plan

  • cargo build --workspace passes
  • cargo clippy --workspace --all-targets --all-features clean
  • cargo nextest run --workspace — 363 tests pass
  • cargo check --target riscv32imac-unknown-none-elf --no-default-features (no_std) passes
  • Regenerated 21 test_halted_*.json testdata files

…tionResult`

Logs emitted before a revert or halt were previously discarded. This
preserves them by adding `logs: Vec<Log>` to both variants so that
downstream consumers can inspect pre-failure logs.
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 12, 2026

Merging this PR will improve performance by 3.62%

⚡ 1 improved benchmark
✅ 172 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
blake2/2_rounds 3.3 µs 3.2 µs +3.62%

Comparing logs (9d07973) with main (0ee852c)

Open in CodSpeed

@rakita rakita merged commit 0b34496 into main Feb 13, 2026
31 checks passed
@github-actions github-actions bot mentioned this pull request Feb 12, 2026
@rakita rakita deleted the logs branch February 13, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants