feat(cfg): add EIP-7708 configuration options#3395
Merged
Conversation
Merging this PR will degrade performance by 4.32%
Performance Changes
Comparing 
|
Add two configuration options to CfgEnv: - `amsterdam_eip7708_disabled`: Completely disables EIP-7708 ETH transfer logs - `amsterdam_eip7708_delayed_burn_disabled`: Disables delayed burn logging for self-destructed accounts. This can be disabled for performance reasons as it requires storing and iterating over all self-destructed accounts. When disabled, the logging can be done outside of revm when applying accounts to database state. Also adds corresponding trait methods to `Cfg` and `JournalTr` traits.
Extract `spec`, `eip7708_disabled`, and `eip7708_delayed_burn_disabled` fields from `JournalInner` into a new `JournalCfg` struct. This groups related configuration together and makes the code more organized.
rakita
force-pushed
the
eip7708-cfg-options
branch
from
c8dcf0d to
7c7e7cf
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
amsterdam_eip7708_disabledconfig to completely disable EIP-7708 ETH transfer logsamsterdam_eip7708_delayed_burn_disabledconfig to disable delayed burn logging for self-destructed accounts (can be disabled for performance reasons as it requires storing and iterating over all self-destructed accounts)JournalCfgstruct for better organizationTest plan
cargo nextest run --workspacecargo clippy --workspace --all-targets --all-features