Skip to content

Deprecate nonce_bump_journal_entry and caller_accounting_journal_entry functions #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakita merged 1 commit into from
Jan 28, 2026
Merged

Deprecate nonce_bump_journal_entry and caller_accounting_journal_entry functions #3367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/context/interface/src/journaled_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ pub trait JournalTr {
) -> Option<TransferError>;

/// Increments the balance of the account.
#[deprecated]
fn caller_accounting_journal_entry(
&mut self,
address: Address,
Expand All @@ -154,6 +155,7 @@ pub trait JournalTr {
) -> Result<(), <Self::Database as Database>::Error>;

/// Increments the nonce of the account.
#[deprecated]
fn nonce_bump_journal_entry(&mut self, address: Address);

/// Loads the account.
Expand Down
2 changes: 2 additions & 0 deletions crates/context/src/journal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ impl<DB: Database, ENTRY: JournalEntryTr> JournalTr for Journal<DB, ENTRY> {
}

#[inline]
#[allow(deprecated)]
fn caller_accounting_journal_entry(
&mut self,
address: Address,
Expand All @@ -248,6 +249,7 @@ impl<DB: Database, ENTRY: JournalEntryTr> JournalTr for Journal<DB, ENTRY> {

/// Increments the nonce of the account.
#[inline]
#[allow(deprecated)]
fn nonce_bump_journal_entry(&mut self, address: Address) {
self.inner.nonce_bump_journal_entry(address)
}
Expand Down
2 changes: 2 additions & 0 deletions crates/context/src/journal/inner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ impl<ENTRY: JournalEntryTr> JournalInner<ENTRY> {

/// Add journal entry for caller accounting.
#[inline]
#[deprecated]
pub fn caller_accounting_journal_entry(
&mut self,
address: Address,
Expand Down Expand Up @@ -305,6 +306,7 @@ impl<ENTRY: JournalEntryTr> JournalInner<ENTRY> {

/// Increments the nonce of the account.
#[inline]
#[deprecated]
pub fn nonce_bump_journal_entry(&mut self, address: Address) {
self.journal.push(ENTRY::nonce_bumped(address));
}
Expand Down
4 changes: 4 additions & 0 deletions examples/cheatcode_inspector/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,12 +235,14 @@ impl JournalTr for Backend {
self.journaled_state.finalize()
}

#[allow(deprecated)]
fn caller_accounting_journal_entry(
&mut self,
address: Address,
old_balance: U256,
bump_nonce: bool,
) {
#[allow(deprecated)]
self.journaled_state
.caller_accounting_journal_entry(address, old_balance, bump_nonce)
}
Expand All @@ -253,7 +255,9 @@ impl JournalTr for Backend {
self.journaled_state.balance_incr(address, balance)
}

#[allow(deprecated)]
fn nonce_bump_journal_entry(&mut self, address: Address) {
#[allow(deprecated)]
self.journaled_state.nonce_bump_journal_entry(address)
}

Expand Down
Loading