fix(bal): fix populated account if pre-state was none#3357
Merged
rakita merged 2 commits intobluealloy:mainfrom Jan 27, 2026
Merged
fix(bal): fix populated account if pre-state was none#3357rakita merged 2 commits intobluealloy:mainfrom
rakita merged 2 commits intobluealloy:mainfrom
Conversation
jsign
changed the title
rakita
reviewed
Jan 27, 2026
| .expect("Invalid account id"); | ||
|
|
||
| // if it is not changed, check if it is none and return it. | ||
| if is_none { |
Member
There was a problem hiding this comment.
There was a problem around empty and non existing account for eip7702 this is why this condition exist here.
But condition is not good, it should take bool from let changed = bal.populate_account_info and only if !changed && is_none { return true;} it true (aka it got changed) put basic to Some(bal_basic)
Contributor
Author
There was a problem hiding this comment.
Makes sense! Pushed a commit to consider the changed criteria.
rakita
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When basic was
None, the function populated account info from BAL but returned early without writing it back, causing the data to be lost.Realized about this while doing some experimentation coding a subblock-prover for Reth in the context of zkVMs, and trying to run some BAL tests.
cc @mattsse