Conversation
Track both previous and current opcode in the analysis loop to handle edge cases where opcodes with immediates (SWAPN, DUPN, EXCHANGE) have their immediate byte appear as STOP. For example, [SWAPN, STOP] needs padding because the STOP is consumed as the immediate operand, not as an actual instruction. Add test to verify [SWAPN, STOP] is padded to [SWAPN, STOP, STOP].
Member
Author
|
Fix for analysis in #3223 |
Remove obsolete GasParams import and argument, use DummyHost::new() constructor instead of unit struct syntax.
Member
Author
|
Waiting fir CI, lgtm |
CodSpeed Performance ReportMerging this PR will improve performance by 3.12%Comparing Summary
Performance Changes
Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prev_opcodeandopcodein the analysis loop to handle edge cases[SWAPN, STOP]is padded to[SWAPN, STOP, STOP]because the STOP is consumed as the immediate operandTest plan
test_bytecode_ends_with_immediate_opcode_and_stop_requires_paddingcovering SWAPN, DUPN, and EXCHANGE