refactor(gas_params): add dedicated GasIds for sstore_refund#3310
Merged
refactor(gas_params): add dedicated GasIds for sstore_refund#3310
Conversation
Add `sstore_set_refund` and `sstore_reset_refund` GasIds so that `sstore_refund` no longer depends on `sstore_set_without_load_cost` and `sstore_reset_without_cold_load_cost` which are used in `sstore_dynamic_gas`. This allows the two functions to have independent gas parameters while maintaining the same values.
rakita
force-pushed
the
refactor/sstore-refund-params
branch
from
3bc7889 to
c31de6e
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
rakita
force-pushed
the
refactor/sstore-refund-params
branch
2 times, most recently
from
53c8011 to
c31de6e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sstore_set_refundandsstore_reset_refundGasIds (indices 37-38)sstore_refundto use these new dedicated parameters instead ofsstore_set_without_load_costandsstore_reset_without_cold_load_costsstore_refundfromsstore_dynamic_gasallowing independent parameter configuration while maintaining the same valuesTest plan
test_gas_id_name_and_from_str_coveragetest updated and passing