fix: add a test utility function to generate memory input opcodes#3280
Merged
rakita merged 4 commits intobluealloy:mainfrom Feb 23, 2026
Merged
fix: add a test utility function to generate memory input opcodes#3280rakita merged 4 commits intobluealloy:mainfrom
rakita merged 4 commits intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
rakita
reviewed
Jan 9, 2026
crates/bytecode/src/utils.rs
Outdated
| use std::str::FromStr; | ||
|
|
||
| /// Constructs bytecode for inserting input into memory | ||
| pub fn build_memory_input_opcodes(hex_input: &str) -> Result<Vec<u8>> { |
Member
There was a problem hiding this comment.
No need for this to be string, &[u8] is fine. Additionally it should have a offset
rakita
reviewed
Jan 9, 2026
|
|
||
| opcodes.extend_from_slice(chunk); | ||
|
|
||
| opcodes.push(opcode::MSTORE); |
Member
There was a problem hiding this comment.
MSTORE uses two items, where one is offset https://www.evm.codes/
rakita
reviewed
Jan 9, 2026
crates/bytecode/src/utils.rs
Outdated
| #[cfg(test)] | ||
| pub mod test { | ||
| use crate::opcode; | ||
| use alloy_primitives::{hex, Bytes}; |
Member
There was a problem hiding this comment.
use primitives::Bytes no need to introduce alloy_primitives or anyhow
Contributor
Author
There was a problem hiding this comment.
Removed alloy-primitives dev-dependency in commit 35ea2a2, since fixed the argument to bytes.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3277