Conversation
431d280 to
c551650
Compare
CodSpeed Performance ReportMerging #3250 will not alter performanceComparing Summary
|
f690365 to
75c49f0
Compare
rakita
reviewed
Dec 23, 2025
DaniPopes
approved these changes
Dec 23, 2025
rakita
reviewed
Dec 23, 2025
Member
|
ci error not related and it was already passing before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GMP gives us higher performance modexp which is necessary for long-tail Ethereum blocks e.g. involving Aztec or ZKSync.
Rug doesn't let us dynamically link GMP so as to make use of it w/o having to relicense Revm/Reth.
Instead, we bind to it over FFI dynamically using the
use-system-libsfeature of https://gitlab.com/tspiteri/gmp-mpfr-sys/-/blob/master/build.rs#L1010.This enables using GMP in Reth