Skip to content

deps: enable foldhash feature of alloy-primitives#3239

Closed
shekhirin wants to merge 1 commit intomainfrom
alexey/alloy-primitives-foldhash
Closed

deps: enable foldhash feature of alloy-primitives#3239
shekhirin wants to merge 1 commit intomainfrom
alexey/alloy-primitives-foldhash

Conversation

@shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Dec 18, 2025

Enables map-foldhash feature for alloy-primitives

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 18, 2025

CodSpeed Performance Report

Merging #3239 will improve performances by 22.47%

Comparing alexey/alloy-primitives-foldhash (d71d00a) with main (7b505e6)

Summary

⚡ 105 improvements
✅ 68 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
EXTCODECOPY_50 55.2 µs 53.3 µs +3.66%
ADDRESS_50 19.7 µs 19 µs +3.67%
DUP8_50 24.6 µs 23.8 µs +3.18%
PUSH8_50 19.4 µs 18.8 µs +3.09%
GASLIMIT_50 19.6 µs 18.8 µs +3.87%
DUP9_50 24.4 µs 23.7 µs +3.04%
PUSH6_50 19.6 µs 18.9 µs +3.79%
EXTCODESIZE_50 46.5 µs 43.5 µs +6.84%
BYTE_50 24.8 µs 24 µs +3.27%
EXTCODEHASH_50 47.1 µs 43.9 µs +7.22%
GAS_50 19.4 µs 18.8 µs +3.25%
PUSH9_50 19.5 µs 18.9 µs +3.24%
PUSH7_50 19.6 µs 19 µs +3.07%
GASPRICE_50 19.8 µs 19 µs +3.98%
CALLDATASIZE_50 19.5 µs 18.8 µs +3.72%
GT_50 24.9 µs 24.1 µs +3.02%
CALL_50 105.9 µs 97.5 µs +8.63%
RETURNDATASIZE_50 19.6 µs 18.9 µs +3.54%
SGT_50 25.4 µs 24.7 µs +3.07%
JUMPDEST_50 16.5 µs 16 µs +3.28%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@shekhirin shekhirin marked this pull request as draft December 18, 2025 19:19
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is feature-gated, it shouldn't be on by default

@rakita
Copy link
Member

rakita commented Dec 24, 2025

Closing this, as it is exposed in the revm crate, so it can be enabled if needed. If it is in default it can mess things up for dependencies

@rakita rakita closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants