Skip to content

opt: optimize precompile extend() #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakita merged 1 commit into from
Dec 2, 2025
Merged

opt: optimize precompile extend() #3192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions crates/precompile/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,18 +263,20 @@ impl Precompiles {
/// Other precompiles with overwrite existing precompiles.
#[inline]
pub fn extend(&mut self, other: impl IntoIterator<Item = Precompile>) {
let items: Vec<Precompile> = other.into_iter().collect::<Vec<_>>();
for item in items.iter() {
if let Some(short_address) = short_address(item.address()) {
self.optimized_access[short_address] = Some(item.clone());
let iter = other.into_iter();
let (lower, _) = iter.size_hint();
self.addresses.reserve(lower);
self.inner.reserve(lower);
for item in iter {
let address = *item.address();
if let Some(short_idx) = short_address(&address) {
self.optimized_access[short_idx] = Some(item.clone());
} else {
self.all_short_addresses = false;
}
self.addresses.insert(address);
self.inner.insert(address, item);
}

self.addresses.extend(items.iter().map(|p| *p.address()));
self.inner
.extend(items.into_iter().map(|p| (*p.address(), p.clone())));
}

/// Returns complement of `other` in `self`.
Expand Down
Loading