feat(precompiles): add performant PrecompileError::OtherCowStr variant#3144
Merged
feat(precompiles): add performant PrecompileError::OtherCowStr variant#3144
Conversation
rakita
commented
Nov 5, 2025
CodSpeed Performance ReportMerging #3144 will not alter performanceComparing Summary
|
rakita
changed the title
klkvr
reviewed
Nov 10, 2025
klkvr
approved these changes
Nov 10, 2025
Merged
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
bluealloy/revm#3144) * feat(precompiles): add performant PrecompileError::OtherStr variant * Apply suggestion from @rakita * use cow * rm Other(String) and use Other(Cow<'static,str>) * fn other_static * revert api change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using &'static str does not require creating a string so it is more performant.