fix: return MemoryLimitOOG when memory_limit is enabled#3109
Merged
rakita merged 1 commit intobluealloy:mainfrom Oct 17, 2025
Merged
fix: return MemoryLimitOOG when memory_limit is enabled#3109rakita merged 1 commit intobluealloy:mainfrom
rakita merged 1 commit intobluealloy:mainfrom
Conversation
f9033ad to
e9a6fbd
Compare
CodSpeed Performance ReportMerging #3109 will improve performances by 3.73%Comparing Summary
Benchmarks breakdown
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reintroduces memory memory limit enforcement when
memory_limitfeature is used.Currently, EVM configuration allows specifying
memory_limithere, but the limit is not actually enforced anywhere. It appears that enforcement logic was unintentionally dropped in this major refactor. On top of that, in another refactor,MemoryOOGwas replaced withMemoryLimitOOG. This PR restores the original semantics of these two instruction results.Context
We run Reth with gas cap set to
uint64::MAXto allow for complex EVM computation. Without memory limit enforcement, this configuration risks out-of-memory crashes if a buggy contract triggers invalid allocations (e.g.,MSTOREwith an invalid offset). The included unit test demonstrates this scenario.