Skip to content

Comments

chore(op): use helper function in validate against state#3069

Merged
rakita merged 2 commits intomainfrom
rakita/helper-op-validate-agains
Oct 20, 2025
Merged

chore(op): use helper function in validate against state#3069
rakita merged 2 commits intomainfrom
rakita/helper-op-validate-agains

Conversation

@rakita
Copy link
Member

@rakita rakita commented Oct 9, 2025

Refactor of op revm validate_against_state_and_deduct_caller function so it uses the helper function from mainnet.

tx_cost_with_tx is used to fetch additional cost of op tx and calculate_caller_fee for calculation of tx fee from mainnet.

Extracted from #2991

@rakita rakita requested review from klkvr and mattsse October 9, 2025 13:02
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 9, 2025

CodSpeed Performance Report

Merging #3069 will not alter performance

Comparing rakita/helper-op-validate-agains (a661d7b) with main (273ddf3)

Summary

✅ 173 untouched

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is equivalent but would appreciate another sanity review by @klkvr

@rakita rakita merged commit e9fca7e into main Oct 20, 2025
31 checks passed
@github-actions github-actions bot mentioned this pull request Oct 20, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 21, 2026
@rakita rakita deleted the rakita/helper-op-validate-agains branch February 16, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants