fix(op-revm): return error instead of panic when enveloped_tx is missing#3055
Merged
rakita merged 3 commits intobluealloy:mainfrom Oct 7, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #3055 will not alter performanceComparing Summary
|
rakita
reviewed
Oct 6, 2025
Co-authored-by: rakita <rakita@users.noreply.github.com>
Merged
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
…ing (bluealloy/revm#3055) * fix(op-revm): return error instead of panic when enveloped_tx is missing * Update crates/op-revm/src/handler.rs Co-authored-by: rakita <rakita@users.noreply.github.com> * fmt --------- Co-authored-by: rakita <rakita@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace expect() with a graceful error in validate_against_state_and_deduct_caller for non-deposit transactions when enveloped_tx is missing. This unifies behavior with reward_beneficiary, avoids process panics on malformed/external inputs (OpTxTr trait boundary), and aligns with the builder’s contract where missing enveloped bytes are a validation error, not an unreachable state.