fix(bytecode): exclude MLOAD from modifies_memory and update test#3004
Merged
rakita merged 1 commit intobluealloy:mainfrom Sep 24, 2025
Merged
Conversation
Contributor
GarmashAlex
commented
Sep 22, 2025
- MLOAD only reads from memory; it does not write to it. Including it in OpCode::modifies_memory misclassifies read-only behavior as memory-modifying.
- Memory expansion (zero-filling) during reads is an allocation side effect, not a semantic write by the opcode itself. This aligns with interpreter implementations and EVM references.
- Updated the test to expect false for MLOAD, kept MSTORE as modifying, and ADD as non-modifying.
- This improves correctness for analyzers/inspectors relying on opcode classification and keeps consistency with other read-only ops (e.g., KECCAK256, RETURN) that also expand memory but aren’t flagged as modifying.
CodSpeed Performance ReportMerging #3004 will not alter performanceComparing Summary
|
rakita
approved these changes
Sep 24, 2025
Member
rakita
left a comment
There was a problem hiding this comment.
True mload does not change the memory.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.